Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): clarify in docs that Well.has_tip checks only for clean tips #17412

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Feb 4, 2025

Closes RQA-3790

Overview

Well.has_tip property has been checking for only clean tips since API v2.2 but the docstrings don't mention that. That has understandably caused some confusion in protocol behaviors. This PR helps mitigate that issue by clarifying the exact behavior of this property

Review requests

Is the language clear enough?

Risk assessment

None.

@sanni-t sanni-t requested review from ecormany and jwwojak February 4, 2025 15:32
@sanni-t sanni-t requested a review from a team as a code owner February 4, 2025 15:32
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement.

I think we should define what we mean by "clean"/"dirty", if we can. I think it's in fact a question of whether a pipette has picked it up, right? But it sounds like it could also mean whether a pipette has aspirated liquid into it.

@jwwojak
Copy link
Contributor

jwwojak commented Feb 4, 2025

I believe @SyntaxColoring is correct here.

I think it's in fact a question of whether a pipette has picked it up, right?

For example, the section on working with used tips indicates a tip is "used" after being picked up.

So does picked up = used and/or dirty in this case, even if it is never used for anything? If this is the case maybe "clean" or "unclean" aren't the right words to use. For example, when sterility is required, maybe just touching the tip or picking it up is enough to render it "unclean." The words "used" and "unused" seem more accurate and neutral.

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears I added my comments in the wrong place. Please see #17412 (comment)

@SyntaxColoring
Copy link
Contributor

OK yeah, if other parts of the docs say "used", then we should make sure the terminology matches.

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
lgtm

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me once the nested list syntax error is resolved. Thanks!

api/src/opentrons/protocol_api/labware.py Outdated Show resolved Hide resolved
@sanni-t sanni-t merged commit 94bd0e9 into edge Feb 6, 2025
24 checks passed
@sanni-t sanni-t deleted the RQA-3790-specify_has_tip_checks_clean_tips_only branch February 6, 2025 20:17
sanni-t added a commit that referenced this pull request Feb 6, 2025
…ips (#17412)

Closes RQA-3790

# Overview

`Well.has_tip` property has been checking for only clean/ unused tips since API
v2.2 but the docstrings don't mention that. That has understandably
caused some confusion in protocol behaviors. This PR helps mitigate that
issue by clarifying the exact behavior of this property

## Risk assessment

None.

---------

Co-authored-by: Max Marrone <[email protected]>
sanni-t added a commit that referenced this pull request Feb 6, 2025
…ips (#17455)

Cherry-picked commit for 8.3.0 release branch

Original PR: #17412 
Closes RQA-3790

# Overview

`Well.has_tip` property has been checking for only clean/ unused tips
since API v2.2 but the docstrings don't mention that. That has
understandably caused some confusion in protocol behaviors. This PR
helps mitigate that issue by clarifying the exact behavior of this
property

## Risk assessment

None.

Co-authored-by: Max Marrone <[email protected]>
TamarZanzouri pushed a commit that referenced this pull request Feb 11, 2025
…ips (#17412)

Closes RQA-3790

# Overview

`Well.has_tip` property has been checking for only clean/ unused tips since API
v2.2 but the docstrings don't mention that. That has understandably
caused some confusion in protocol behaviors. This PR helps mitigate that
issue by clarifying the exact behavior of this property

## Risk assessment

None.

---------

Co-authored-by: Max Marrone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants