fix(api): correctionVolume can be negative #17413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17413 +/- ##
=======================================
Coverage 17.34% 17.34%
=======================================
Files 3128 3128
Lines 226114 226114
Branches 6884 6884
=======================================
Hits 39225 39225
Misses 186889 186889
Flags with carried forward coverage won't be shown. Click here to find out more. |
andySigler
deleted the
fix-api-liquid-classes-negative-correction-volumes
branch
caila-marashaj
pushed a commit
that referenced
this pull request
Feb 11, 2025
TamarZanzouri
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Correction volume can be negative, and is for example in glycerol_50
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment