chore(release): merge chore_release-pd-8.4.0 into edge
#17452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17377) * fix(protocol-designer): modify tiprack status check for deselecting
…er airGap (#17392) closes RQA-3913 When `airGapinplace` was implemented, i incorrectly got rid of the `dispense` `meta: isAirGap` information. This resulted in the `robotState` liquid state incorrectly getting updated for dispense after `airGapInPlace`. This PR adds the dispense `meta: isAirGap` back, purely for the robot state purposes. Otherwise, i was not sure how to not update the dispense robot state.
* fix(protocol-designer): modify the list button width
This PR properly displays error messages for bad engage heights with both the GEN1 and GEN2 magnetic modules in PD. The footprint here is large, because we need to pass the module model to the error creators that determine the module's valid engage height range (specific to model). We also need to pass moduleEntities down through createPresavedStepForm and its patches to set the module model when the form is created or the moduleId is updated. Last, we need to add a migration for the new `moduleModel` field for magnetic module steps. Closes RQA-3911
This PR fixes the wrapping behavior for StepSummary elements. Each component (StyledTrans) of the StepSummary should wrap to the next line dynamically, not have a pre-defined row. Closes RQA-3698
If a user has added labware in column 4 provided by a staging area, that labware should be deleted if the hardware is changed such that the staging area is removed. Closes RQA-3907
* fix(protocol-designer): fix staging area logic
* fix(protocol-designer, components) fix deck view size issue
* fix(protocol-designer): fix empty selector button size issue
* fix(components): Fix large button outline issue
* fix(protocol-designer): fix step overflow menu position
* fix(components): add focus-visible style to list button
This PR fixes a bug in the temperature step form where a form error is incorrecly returned if a user has not entered a temperature, even if the setTemperature ield is set to false. The error arose from incorrectly parsing the string literals for 'true' / 'false'. Also, this PR fixes the step summary text for deactivating a temperature module Closes RQA-3947, RQA-3948
ncdiehl11
added
the
DO NOT MERGE
|
i recommend closing this and opening a new merge back with the full 8.4.0 commit history 😄 |
|
moved to #17507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Mergeback of PD release 8.4.0 changes into
edgeas of alpha.2.Test Plan and Hands on Testing
CI, review conflict files
Changelog
Resolve conflicts in:
protocol-designer/fixtures/protocol/8/doItAllV4MigratedToV8.json
protocol-designer/fixtures/protocol/8/doItAllV7MigratedToV8.json
protocol-designer/fixtures/protocol/8/newAdvancedSettingsAndMultiTemp.json
Review requests
Risk assessment
Low. Only conflict files were PD test fixtures. Only shared code touched is small components style changes