Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): merge chore_release-pd-8.4.0 into edge #17452

Closed
wants to merge 21 commits into from

fix pd test fixture

899d36c
Select commit
Loading
Failed to load commit list.
Closed

chore(release): merge chore_release-pd-8.4.0 into edge #17452

fix pd test fixture
899d36c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 0s

59.66% (+39.59%) compared to 73b70f4

View this Pull Request on Codecov

59.66% (+39.59%) compared to 73b70f4

Details

Codecov Report

Attention: Patch coverage is 49.44179% with 317 lines in your changes missing coverage. Please review.

Project coverage is 59.66%. Comparing base (73b70f4) to head (899d36c).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...r/src/pages/Designer/ProtocolSteps/StepSummary.tsx 6.02% 78 Missing ⚠️
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 68.14% 43 Missing ⚠️
...ner/src/pages/Designer/DeckSetup/FixtureRender.tsx 0.00% 43 Missing ⚠️
...ols/ThermocyclerTools/ThermocyclerProfileModal.tsx 0.00% 26 Missing ⚠️
protocol-designer/src/steplist/formLevel/errors.ts 19.23% 21 Missing ⚠️
...organisms/EditInstrumentsModal/PipetteOverview.tsx 0.00% 19 Missing ⚠️
...c/pages/CreateNewProtocolWizard/SelectPipettes.tsx 0.00% 15 Missing ⚠️
...StepTools/AbsorbanceReaderTools/Initialization.tsx 0.00% 14 Missing ⚠️
...rotocol-designer/src/step-forms/selectors/index.ts 30.00% 14 Missing ⚠️
...col-designer/src/pages/Designer/DeckSetup/utils.ts 7.69% 12 Missing ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17452       +/-   ##
===========================================
+ Coverage   20.07%   59.66%   +39.59%     
===========================================
  Files        3187     3186        -1     
  Lines      229811   230221      +410     
  Branches     8190    17721     +9531     
===========================================
+ Hits        46132   137368    +91236     
+ Misses     183679    92664    -91015     
- Partials        0      189      +189
Files with missing lines Coverage Δ
components/src/atoms/ListButton/index.tsx 95.12% <100.00%> (+0.25%) ⬆️
...mponents/src/atoms/buttons/EmptySelectorButton.tsx 97.50% <ø> (-0.12%) ⬇️
components/src/atoms/buttons/LargeButton.tsx 99.01% <100.00%> (+0.50%) ⬆️
...gner/src/molecules/DropdownStepFormField/index.tsx 57.00% <100.00%> (+0.81%) ⬆️
.../src/molecules/ToggleExpandStepFormField/index.tsx 80.23% <100.00%> (+0.23%) ⬆️
...rc/pages/CreateNewProtocolWizard/SelectModules.tsx 43.51% <100.00%> (ø)
...signer/src/pages/CreateNewProtocolWizard/utils.tsx 77.85% <100.00%> (+4.68%) ⬆️
...rc/pages/Designer/OffDeck/HighlightOffdeckSlot.tsx 3.63% <ø> (ø)
...ocol-designer/src/pages/Designer/OffDeck/index.tsx 27.04% <ø> (ø)
.../pages/Designer/ProtocolSteps/DraggableSidebar.tsx 77.41% <100.00%> (ø)
... and 38 more

... and 1923 files with indirect coverage changes

View more details on Codecov