Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer, shared-data): update command schema to v10 #17550

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 18, 2025

Overview

As an oversight, PD 8.4.0 maintained exporting protocols with command schema v8. This PR updates the command schema to v10.

Test Plan and Hands on Testing

Changelog

  • update command schema in fileCreator.ts -> createFile
  • update cypress migration fixtures

Review requests

  • see test plan

Risk assessment

low-ish

As an oversight, PD 8.4.0 maintained exporting protocols with command schema v8. This PR updates the command schema to v10.
@ncdiehl11 ncdiehl11 requested review from shlokamin and ddcc4 February 18, 2025 21:49
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 18, 2025 21:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 18, 2025 21:49
@ncdiehl11 ncdiehl11 self-assigned this Feb 18, 2025
@ncdiehl11 ncdiehl11 merged commit 57e5a33 into chore_release-pd-8.4.2_airgap-hotfix Feb 18, 2025
48 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-command-schema branch February 18, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants