refactor(api): Delete obsolete todo comments #17554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Delete some todo comments in the
loadLabware
andloadLid
Protocol Engine command implementations.Emphasis mine:
As far as I can tell, this is not true. These checks happen inside Protocol Engine command implementations, which, architecturally, commit all their changes only at the very end, once they've completed without errors.
These comments may have been inherited from
opentrons.protocol_api
-level code, which does still have this problem. They may also have been inherited from older hacky Protocol Engine code that did directly modify state in the middle of a command, code that I believe and hope we've stamped out by now.Test Plan and Hands on Testing
None needed.
Review requests
Am I correct, or is there something weird about these commands where they do modify Protocol Engine state before they complete?
Risk assessment
No risk.