feat(api): show air gap volume in simulate log #17569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When
simulate
-ing a protocol, the logs just show this for anAIR_GAP
command:whereas the other commands have useful info. I want to see how much air we're aspirating for the air gap. After this change, the logs will look like this:
Test Plan and Hands on Testing
I'm mainly relying on the CI tests. I did run
simulate
with this change and checked the output manually.Review requests
I am not too familiar with this part of the code.
legacy_commands
? What does "legacy" refer to?legacy_commands/commands.py
. How was the code able to work when the function was declared asdef air_gap()
with no arguments before this change?Risk assessment
Medium? I don't know if there are consumers of the simulate log who expect the payload never to change.