Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): Store overpressure count on plungers #17839

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

ryanthecoder
Copy link
Contributor

@ryanthecoder ryanthecoder commented Mar 20, 2025

Overview

This corresponds with a firmware PR that enables the firmware to store lifetime overpressure errors in the eeprom and report them out separately from regular motion errors.

also does a little touch-up where the auto-gen can IDs had gotten out of sync, the missing one is here now since this is the source of truth.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner March 20, 2025 19:53
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.42%. Comparing base (68263e5) to head (9b2369b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17839   +/-   ##
=======================================
  Coverage   23.42%   23.42%           
=======================================
  Files        2891     2891           
  Lines      222711   222711           
  Branches    19018    19018           
=======================================
  Hits        52171    52171           
  Misses     170529   170529           
  Partials       11       11           
Flag Coverage Δ
protocol-designer 18.87% <ø> (ø)
step-generation 4.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant