Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Protocol Details ODD support for lids & lid stacks #17842

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Mar 20, 2025

Overview

This PR adds support for displaying lid and lid stack info in protocol details labware tab on ODD and brings protocol details deck map on ODD into alignment with desktop, which is not interactive

Test Plan and Hands on Testing

  1. Look at a protocol with a tiprack lid on ODD, see that the lid name is represented
  2. Look at a protocol with a lid stack on ODD, see that the necessary labware and quantity is represented
  3. Look at protocol deck map on ODD, see that it is no longer interactive and matches the map on desktop
Screenshot 2025-03-20 at 4 19 30 PM Screenshot 2025-03-20 at 5 06 40 PM Screenshot 2025-03-20 at 5 06 47 PM

Changelog

  1. Remove all interaction, highlight, stacking icon behavior from ProtocolDeck and ODD protocol details deck map
  2. Create new util getRequiredLabwareDetailFromLoadCommands to be shared between protocol details desktop and ODD which compiles all labware, their corresponding lids, and quantities needed for the protocol
  3. Adapt protocol details to use this info and properly render it

Review requests

Check out the util - I think this abstraction makes sense and can be easily extended to account for stacker commands

Risk assessment

Low

@smb2268 smb2268 requested a review from a team March 20, 2025 21:07
@smb2268 smb2268 self-assigned this Mar 20, 2025
@smb2268 smb2268 requested a review from a team as a code owner March 20, 2025 21:07
@smb2268 smb2268 requested review from mjhuff and removed request for a team March 20, 2025 21:07
@smb2268 smb2268 requested review from TamarZanzouri and a team March 20, 2025 21:09
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 186 lines in your changes missing coverage. Please review.

Project coverage is 24.18%. Comparing base (a9d6b6f) to head (9b92450).
Report is 73 commits behind head on edge.

Files with missing lines Patch % Lines
...rdware-sim/ProtocolDeck/utils/getLabwareInSlots.ts 0.00% 61 Missing ⚠️
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 0.00% 57 Missing ⚠️
app/src/pages/ODD/ProtocolDetails/Labware.tsx 0.00% 30 Missing ⚠️
app/src/pages/ODD/QuickTransferDetails/Labware.tsx 0.00% 17 Missing ⚠️
...Desktop/ProtocolDetails/ProtocolLabwareDetails.tsx 0.00% 13 Missing ⚠️
...rces/protocols/hooks/useRequiredProtocolLabware.ts 0.00% 3 Missing ⚠️
components/src/hardware-sim/ProtocolDeck/index.tsx 0.00% 3 Missing ⚠️
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx 0.00% 1 Missing ⚠️
.../transformations/commands/transformations/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17842      +/-   ##
==========================================
- Coverage   24.35%   24.18%   -0.18%     
==========================================
  Files        2949     2992      +43     
  Lines      227263   232434    +5171     
  Branches    19137    19925     +788     
==========================================
+ Hits        55354    56207     +853     
- Misses     171899   176217    +4318     
  Partials       10       10              
Flag Coverage Δ
protocol-designer 18.88% <0.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/pages/ODD/ProtocolDetails/Deck.tsx 0.00% <ø> (ø)
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx 0.00% <0.00%> (ø)
.../transformations/commands/transformations/index.ts 0.00% <0.00%> (ø)
...rces/protocols/hooks/useRequiredProtocolLabware.ts 0.00% <0.00%> (ø)
components/src/hardware-sim/ProtocolDeck/index.tsx 3.84% <0.00%> (+2.29%) ⬆️
...Desktop/ProtocolDetails/ProtocolLabwareDetails.tsx 0.00% <0.00%> (ø)
app/src/pages/ODD/QuickTransferDetails/Labware.tsx 0.00% <0.00%> (ø)
app/src/pages/ODD/ProtocolDetails/Labware.tsx 0.00% <0.00%> (ø)
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 0.00% <0.00%> (ø)
...rdware-sim/ProtocolDeck/utils/getLabwareInSlots.ts 1.48% <0.00%> (-0.04%) ⬇️

... and 162 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! lgtm

@smb2268 smb2268 merged commit fa3180d into edge Mar 20, 2025
45 of 46 checks passed
@smb2268 smb2268 deleted the app_protocol-details-odd branch March 20, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants