Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Protocol Details ODD support for lids & lid stacks #17842

Merged
merged 5 commits into from
Mar 20, 2025

Remove unused type imports

9b92450
Select commit
Loading
Failed to load commit list.
Merged

feat(app): Protocol Details ODD support for lids & lid stacks #17842

Remove unused type imports
9b92450
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2025 in 1s

24.18% (-0.18%) compared to a9d6b6f

View this Pull Request on Codecov

24.18% (-0.18%) compared to a9d6b6f

Details

Codecov Report

Attention: Patch coverage is 0% with 186 lines in your changes missing coverage. Please review.

Project coverage is 24.18%. Comparing base (a9d6b6f) to head (9b92450).
Report is 71 commits behind head on edge.

Files with missing lines Patch % Lines
...rdware-sim/ProtocolDeck/utils/getLabwareInSlots.ts 0.00% 61 Missing ⚠️
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 0.00% 57 Missing ⚠️
app/src/pages/ODD/ProtocolDetails/Labware.tsx 0.00% 30 Missing ⚠️
app/src/pages/ODD/QuickTransferDetails/Labware.tsx 0.00% 17 Missing ⚠️
...Desktop/ProtocolDetails/ProtocolLabwareDetails.tsx 0.00% 13 Missing ⚠️
...rces/protocols/hooks/useRequiredProtocolLabware.ts 0.00% 3 Missing ⚠️
components/src/hardware-sim/ProtocolDeck/index.tsx 0.00% 3 Missing ⚠️
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx 0.00% 1 Missing ⚠️
.../transformations/commands/transformations/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17842      +/-   ##
==========================================
- Coverage   24.35%   24.18%   -0.18%     
==========================================
  Files        2949     2992      +43     
  Lines      227263   232434    +5171     
  Branches    19137    19925     +788     
==========================================
+ Hits        55354    56207     +853     
- Misses     171899   176217    +4318     
  Partials       10       10              
Files with missing lines Coverage Δ
app/src/pages/ODD/ProtocolDetails/Deck.tsx 0.00% <ø> (ø)
...pp/src/organisms/Desktop/ProtocolDetails/index.tsx 0.00% <0.00%> (ø)
.../transformations/commands/transformations/index.ts 0.00% <0.00%> (ø)
...rces/protocols/hooks/useRequiredProtocolLabware.ts 0.00% <0.00%> (ø)
components/src/hardware-sim/ProtocolDeck/index.tsx 3.84% <0.00%> (+2.29%) ⬆️
...Desktop/ProtocolDetails/ProtocolLabwareDetails.tsx 0.00% <0.00%> (ø)
app/src/pages/ODD/QuickTransferDetails/Labware.tsx 0.00% <0.00%> (ø)
app/src/pages/ODD/ProtocolDetails/Labware.tsx 0.00% <0.00%> (ø)
...tions/getRequiredLabwareDetailsFromLoadCommands.ts 0.00% <0.00%> (ø)
...rdware-sim/ProtocolDeck/utils/getLabwareInSlots.ts 1.48% <0.00%> (-0.04%) ⬇️

... and 162 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.