fix(app): Fix accidental polling when a query is initially disabled#17853
Merged
SyntaxColoring merged 1 commit intoedgefrom Mar 21, 2025
Merged
fix(app): Fix accidental polling when a query is initially disabled#17853SyntaxColoring merged 1 commit intoedgefrom
SyntaxColoring merged 1 commit intoedgefrom
Conversation
1 task
mjhuff
approved these changes
Mar 21, 2025
Contributor
mjhuff
left a comment
mjhuff
left a comment
There was a problem hiding this comment.
Noice. Glad this hasn't bit us anywhere in prod :)
SyntaxColoring
added a commit
that referenced
this pull request
Mar 21, 2025
…17832) ## Overview The client-side half of EXEC-1342. ## Test Plan and Hands on Testing * [x] I guess at this point we can turn on the feature flag and try this out by entering LPC on one client and changing offsets on another? * Tested with a merge of this PR, #17853, #17817, and #17850. ## Changelog The client was polling `POST /labwareOffsets/searches`. This switches it to only happen when the client receives a notification from the server that offsets have changed, with a polling fallback. I'm entirely cargo-culting the patterns from the existing `useNotify___()` hooks. ## Risk assessment Medium. I don't think we have a good way to integration-test this kind of thing, so there are risks of things like missed updates, or inadvertent polling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
While testing EXEC-1342, we noticed a bug in our notifications machinery that would cause the app to poll even when MQTT was available and it shouldn't have to.
Details
Specifically, the bug would happen for queries that started off with
optionsof{enabled: false}and became{enabled: true}later on. Here is the motivating example.The
useNotifyDataReadyhook had a piece of state,isNotifyEnabled, that would accidentally permanently latch tofalsewhenever the hook saw{enabled: false}.Test Plan and Hands on Testing
Tested as part of #17832 by monitoring the network logs.
Review requests
Makes sense? Names good?
Risk assessment
Medium. This is common code for a lot of stuff, and it's hard to test.