Conversation
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.13 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Spring Boot version from 3.5.12 to 3.5.13 across multiple POM files. Feedback indicates that the 3.5.x version line for Spring Boot does not exist, which will result in build failures due to dependency resolution errors. Additionally, it was suggested to centralize the version management in a parent property to improve maintainability and consistency.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-dependencies</artifactId> | ||
| <version>3.5.12</version> | ||
| <version>3.5.13</version> |
There was a problem hiding this comment.
The specified Spring Boot version 3.5.13 appears to be incorrect. Official Spring Boot releases do not have a 3.5.x version line. This will cause the build to fail due to a dependency resolution error. Please verify the correct version to use. For reference, recent stable Spring Boot 3 releases are in the 3.3.x and 3.2.x lines.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.5.12</version> | ||
| <version>3.5.13</version> |
There was a problem hiding this comment.
The specified spring-boot-starter-parent version 3.5.13 appears to be incorrect, as there is no official 3.5.x release line for Spring Boot. This will cause the build to fail because the parent POM cannot be resolved. Please use a valid, existing Spring Boot version.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-dependencies</artifactId> | ||
| <version>3.5.12</version> | ||
| <version>3.5.13</version> |
There was a problem hiding this comment.
To improve maintainability and ensure version consistency across modules, consider defining the Spring Boot version as a property (e.g., <spring-boot.version>) in the parent lighty-parent/pom.xml. You could then reference it here and in other modules using ${spring-boot.version}. This centralizes dependency version management, making future updates easier and less error-prone.
1 participant
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.13