Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighty-core/lighty-controller-spring-di/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>3.5.12</version>
<version>3.5.13</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified Spring Boot version 3.5.13 appears to be incorrect. Official Spring Boot releases do not have a 3.5.x version line. This will cause the build to fail due to a dependency resolution error. Please verify the correct version to use. For reference, recent stable Spring Boot 3 releases are in the 3.3.x and 3.2.x lines.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure version consistency across modules, consider defining the Spring Boot version as a property (e.g., <spring-boot.version>) in the parent lighty-parent/pom.xml. You could then reference it here and in other modules using ${spring-boot.version}. This centralizes dependency version management, making future updates easier and less error-prone.

<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.5.12</version>
<version>3.5.13</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified spring-boot-starter-parent version 3.5.13 appears to be incorrect, as there is no official 3.5.x release line for Spring Boot. This will cause the build to fail because the parent POM cannot be resolved. Please use a valid, existing Spring Boot version.

<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down
Loading