Conversation
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.13 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 630db9f)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Spring Boot version from 3.5.12 to 3.5.13 in the lighty-core and lighty-examples modules. The feedback suggests using a Maven property to manage the Spring Boot version centrally rather than hardcoding it in multiple POM files to improve maintainability and ensure consistency.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-dependencies</artifactId> | ||
| <version>3.5.12</version> | ||
| <version>3.5.13</version> |
There was a problem hiding this comment.
To improve maintainability and ensure version consistency across modules, it's better to manage the Spring Boot version using a property. This avoids hardcoding the version in multiple places and makes future updates easier.
I recommend defining a property like <spring-boot.version>3.5.13</spring-boot.version> in the <properties> section of a parent POM (e.g., lighty-parent/pom.xml) and then referencing it here.
| <version>3.5.13</version> | |
| <version>${spring-boot.version}</version> |
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.5.12</version> | ||
| <version>3.5.13</version> |
There was a problem hiding this comment.
For better maintainability, it's a good practice to define the parent version as a property. This makes it easier to manage and update.
You can add a <spring-boot.version>3.5.13</spring-boot.version> property to the <properties> section of this pom.xml and use it here.
| <version>3.5.13</version> | |
| <version>${spring-boot.version}</version> |
1 participant
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.13
(cherry picked from commit 630db9f)