Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighty-core/lighty-controller-spring-di/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>3.5.12</version>
<version>3.5.13</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure version consistency across modules, it's better to manage the Spring Boot version using a property. This avoids hardcoding the version in multiple places and makes future updates easier.

I recommend defining a property like <spring-boot.version>3.5.13</spring-boot.version> in the <properties> section of a parent POM (e.g., lighty-parent/pom.xml) and then referencing it here.

Suggested change
<version>3.5.13</version>
<version>${spring-boot.version}</version>

<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.5.12</version>
<version>3.5.13</version>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's a good practice to define the parent version as a property. This makes it easier to manage and update.

You can add a <spring-boot.version>3.5.13</spring-boot.version> property to the <properties> section of this pom.xml and use it here.

Suggested change
<version>3.5.13</version>
<version>${spring-boot.version}</version>

<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down
Loading