Added new patches for GT3, GT4 and some other games#602
Added new patches for GT3, GT4 and some other games#602R1C3R21 wants to merge 22 commits intoPCSX2:mainfrom
Conversation
The render distance patch got modified to be inside one patch only, added the author for the deinterlacing patch, and reverted back the serial number in the patches.
Some patches did not have an author added to them, and have been put into the pnach for proper attribution. Also, a no interlacing patch for Sly 2 has been added.
The God Hand 16:9 widescreen has been disabled since it no longer works.
|
Regarding the adjustable units cheat, same point I outlined in #521 (comment) applies:
|
|
Damn that was quick to answer. True, I forgot to edit those out since there were so many patches to filter and reorder them that I completely forgot. |
|
Have they been tested? For example, the Gran Turismo 4 No-interlacing patch isn't necessary and even breaks the game. It works fine with automatic interlacing without judder, and with "Bob bff" it works perfectly. |
|
Sorry, the GT3-4 patches were prepared months in advance, and I forgot to check all of them. I will check ASAP the GT4 patches since there are way more patches to check, although I do remember testing out most of them, and being fine. Regardless, I will check them once again to see the current results. |
This won't be accepted then patches can't be added if you know they break something. |
Shall I leave it commented then? Like I have done with the God Hand patch. |
While the patch works, it has been added to the description why it has been disabled.
I did not say that the GT3 60 FPS patch did not work, I said the complete opposite (in fact I have done all of the licenses and most of the game with the patch activated). The problem comes from all of the MIDI songs (main menu, garage, quick race, career mode championship selection...) are accelerated when the patch is activated.
Regarding the GT4 patches, yesterday I tested out my PAL copy and I can confirm that ALL of the cheats work without any issues. I will test out later on the other regions/versions too and see how they fair out. |
Removed patch that a simple deinterlacing change in the PCSX2 settings does better, and also added another issue added by the now deactivated Gran Turismo 3 60 FPS patch.
|
I was referring to the GT3 interlacing patch, as I show in the images with the patch it looks better than without it. |
|
I tested it out and I got pretty inconsistents results for some reason while restarting the game. But closing down the emulator completely helped me obtain the results that you have showed before (specially with the glitchy looking text without the deinterlacing). Kinda strange honestly. |
|
whats the status of this ? |
I have this bookmarked since I still have not been able to test ALL of the GT4 patches. I can confirm that the GT3 ones do fully work, and all of the PAL ones do work, I am just missing the NTSC ones. I'll get around testing them next month. |
|
Now all of the original cheat code for GT4 NTSC-U have been revised, but now I've decided to also check the Vyerq's cheats (https://xn--pckq0c4g.com/codes/GT4#1), and some of them are too interesting to not include. I am currently going through all of them and see which ones can be included. |
|
@Mrlinkwii feel free to merge the PR, or at least someone from the PCSX2 team and to see if you validate all of the new patches uploaded. They were tested thoroughly by me. |
|
@R1C3R21 The code for this patch seems to be missing here.
|
😳 ... It's the same patch, just with the original description done by TheAdmiester that is not really that descriptive of the actual changes done in the patch. On the night variant of the tracks the difference is so minuscule that you cannot even tell the differences, unlike some tracks during the evening, hence why his patch description was rephrased. |
No, what you committed was an empty patch, just the title and the comment. I even quoted, screenshotted and linked it in my previous comment. There's no room for shifting blame to TheAdmiester here. "the actual changes done in the patch" were not there. The patch code is there in TheAdmiester's upstream repo however, so if you copy them, make sure to copy the Deleting the mistake, like you have done in the commits since that comment; is an alternative solution too, I guess. |
I wasn't blaming the mistake to Admeister, I blamed me for the error... IIRC the patch was tested on the NTSC-U version first, and since the patch is exactly the same on both versions, I just copied and pasted the description to the PAL region, and then put the correct patch for the specific region. Keep in mind that I had to check a lot of patches, and I was reordering them to be in alphabetical order. Oh, I just checked that patch. I got confused with the previous one since the names are almost the same. I did remove that one because the changes are just... not there? If someone is able to see the changes let me know, but if these changes are less noticeable than a PS5 vs PS5 Pro comparison, is it even worth it? |
Why is the 60 FPS patch for SCES-50294 (GT3) commented out and then re-added to the patch? Also, the Adjusted triggers sensitivity patch has also been added to this file twice. First instance shows up at line 14 and second instance shows up at line 60 I should point out that #667 has already added these GT3 patches to the main branch |
Oh, so you reenabled it back? Read this: #602 (comment) The other patches were added because if you knew how Git works, you would see that the latest commit was a merge from main... Gonna disable back the 60 FPS patch. Also now that I see it... how the fuck did they allow for these patches when you can see the FIRST comment in this PR?! I want those to be there, but if nobody can make up their own mind... I guess that Silent just got tired of repeating the same stuff over and over. |
This is pretty much my first time using GitHub and committing stuff to it, so I apologise for not being intimately aware of how every part of GitHub fully works. It's stuff I will have to learn and get used to over time if I am going to contribute more
I never re-enabled it. It was already part of the PNACH file. If you check the file changes, you can see that for yourself.
The patches that I added were made by @CookiePLMonster and @AeroWidescreen themselves. I added them purely out of booting up Gran Turismo 3 for the first time on PCSX2, noticing that those patches were available in the NTSC version but not the PAL version, and then asking how to get those patches added. I didn't make any modifications to those patches, except for re-arranging some of the notes to make it look neater and in-line with the already existing patches. The NTSC version of GT3 already had the Adjustable triggers and Adjustable units patches, so I assumed it was safe to just add those two. |






The only worthwhile thing to comment is that the God Hand widescreen patch has been disabled because it no longer works, it just stretches out the image and nothing else, the text still presents issues on the slot machine.