Skip to content

chore: tf2_ros to hpp headers#480

Merged
benemer merged 1 commit into
PRBonn:mainfrom
nobleo:chore/tf2_ros/hpp
Nov 14, 2025
Merged

chore: tf2_ros to hpp headers#480
benemer merged 1 commit into
PRBonn:mainfrom
nobleo:chore/tf2_ros/hpp

Conversation

@Timple

@Timple Timple commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@Timple

Timple commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

My bad, Jazzy sync is being held up. So this won't be available for a few days. Let's wait it out.
In the meanwhile, would you like me to replace iron with kilted in this PR?

@benemer

benemer commented Aug 19, 2025

Copy link
Copy Markdown
Member

First of all, thanks for the fix!

I agree, we should replace Iron with Kilted and Jazzy. But it would be better to do that in a separate PR to keep things isolated. Feel free to open it!

@benemer

benemer commented Aug 19, 2025

Copy link
Copy Markdown
Member

The build works on Rolling with the updated tf2-ros package. Do you know if it will also be updated for the osrf Humble, Jazzy, and Kilted images? I don't know if and how often they update packages.

@Timple

Timple commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

It's backported for sure. I run the testing repos locally and there it works.

@benemer

benemer commented Aug 20, 2025

Copy link
Copy Markdown
Member

I updated the distros for the CI in #481 and checked again, the updated package is not in the osrf/humble image (yet). Guess we have to wait a bit longer.

Alternatively, we could add a temporal fix in the CI by manually updating the package before testing the build.

@benemer

benemer commented Aug 20, 2025

Copy link
Copy Markdown
Member

It's backported for sure. I run the testing repos locally and there it works.

So you downloaded the osrf docker images and were able to build it there? Because in case of osrf/ros:humble-desktop, the version of ros-humble-tf2-ros is still

root@0f9c1250391b:/# apt-cache policy ros-humble-tf2-ros
ros-humble-tf2-ros:
  Installed: 0.25.15-1jammy.20250719.025642

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
@Timple

Timple commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

Triggered Ci by rebasing

@mehermvr

Copy link
Copy Markdown
Member

lgtm. @benemer is there anything specific to this pr itself you still want to have a look at? probably earlier there were some checks that were failing i guess, but ci is all green now.

@benemer benemer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too!

@benemer benemer merged commit 69930d8 into PRBonn:main Nov 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants