fix ouster dataloader#495
Merged
Merged
Conversation
saurabh1002
requested review from
benemer,
mehermvr,
nachovizzo and
tizianoGuadagnino
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the kiss_icp Ouster dataset loader to match Ouster SDK API changes and bumps the optional ouster-sdk dependency floor to a newer compatible version.
Changes:
- Bump
ouster-sdkoptional dependency from>=0.11to>=0.15.0. - Update
python/kiss_icp/datasets/ouster.pyto importouster.sdk.coreand referencecore.client/core.XYZLutinstead ofouster.sdk.client.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/pyproject.toml | Raises minimum ouster-sdk version in optional all extra to align with updated loader usage. |
| python/kiss_icp/datasets/ouster.py | Adjusts Ouster SDK imports and symbols to newer API locations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Ouster SDK integration in the
kiss_icpdataset loader to support the latest API changes and ensures compatibility with newer versions. The most important changes are:Ouster SDK API updates:
python/kiss_icp/datasets/ouster.pyto usecoreinstead ofclientfrom theouster.sdkpackage, reflecting upstream changes in the SDK API.clientclasses and methods to use their new locations undercore(e.g.,core.client,core.XYZLut) inpython/kiss_icp/datasets/ouster.py.Dependency version bump:
ouster-sdkfrom0.11to0.15.0inpython/pyproject.tomlto ensure compatibility with the new API usage.