fix(drivers): Do not show warnings if no DShot is configured#26917
Merged
fix(drivers): Do not show warnings if no DShot is configured#26917
Conversation
dakejahl
approved these changes
Mar 31, 2026
hamishwillee
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved Problem
Currently, when no dshot actuator is configured this warning is shown:
The warning seems a bit extreme to me, as there are a lot of setups without any dshot.
And the Error implies that something went wrong, even though everything is just fine.
Solution
Convert the
WARNINGtoINFODo not return an error when the module stops after no channel is configured.
Changelog Entry
For release notes:
Alternatives
It would be better do only remove the warning, if no channel is found and not as generic as this solution, however I was not able to find a good solution for that.
Test coverage
Tested on HW.
With this PR: