Skip to content

fix(drivers): Do not show warnings if no DShot is configured#26917

Merged
dakejahl merged 1 commit intomainfrom
pr-fix-shot-errors
Mar 31, 2026
Merged

fix(drivers): Do not show warnings if no DShot is configured#26917
dakejahl merged 1 commit intomainfrom
pr-fix-shot-errors

Conversation

@ttechnick
Copy link
Copy Markdown
Member

Solved Problem

Currently, when no dshot actuator is configured this warning is shown:

WARN  [dshot] No channels configured
INFO  [dshot] Exiting
ERROR [module] Task start failed (-1)

The warning seems a bit extreme to me, as there are a lot of setups without any dshot.
And the Error implies that something went wrong, even though everything is just fine.

Solution

Convert the WARNING to INFO
Do not return an error when the module stops after no channel is configured.

Changelog Entry

For release notes:

Bugfix: No warning when dshot voluntarily exits

Alternatives

It would be better do only remove the warning, if no channel is found and not as generic as this solution, however I was not able to find a good solution for that.

Test coverage

Tested on HW.
With this PR:

INFO  [dshot] No channels configured
INFO  [dshot] Exiting

@ttechnick ttechnick requested a review from dakejahl March 31, 2026 15:48
@dakejahl dakejahl merged commit 1d81ecb into main Mar 31, 2026
79 checks passed
@dakejahl dakejahl deleted the pr-fix-shot-errors branch March 31, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants