ci(checks): trim matrix, ccache tests, modernize python_checks#27035
Merged
ci(checks): trim matrix, ccache tests, modernize python_checks#27035
Conversation
Port the checks.yml and python_checks.yml improvements from the CI orchestrator branch (mrpollo/ci_orchestration, PR #26257) without doing the full T1/T2 split. checks.yml: - Drop 5 matrix entries the orchestrator removed: tests_coverage, px4_fmu-v2_default stack_check, NO_NINJA_BUILD=1 px4_fmu-v5_default, NO_NINJA_BUILD=1 px4_sitl_default, px4_sitl_allyes. - Remove the codecov/codecov-action@v1 step (deprecated, only ran for the dropped tests_coverage entry). - Wire the setup-ccache / save-ccache composite actions around make tests (cache-key-prefix ccache-sitl, max-size 300M) so repeat runs reuse the SITL build tree. Matches the orchestrator basic-tests job 1:1. python_checks.yml: - Replace the apt-get install python3 + pip install --break-system-packages + hardcoded $HOME/.local/bin paths with actions/setup-python@v5 pinned to 3.10 and plain pip install. - Linters now run from PATH instead of $HOME/.local/bin. Stacks on top of mrpollo/ci-checkout-hygiene (#27032) which shipped fail-fast: true, fetch-depth: 1, and the safe.directory step extraction. Signed-off-by: Ramon Roche <mrpollo@gmail.com>
mrpollo
force-pushed
the
mrpollo/ci-checks-ccache-python
branch
from
b1dc0eb to
7b7e17d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #27032. Ports the
checks.ymlandpython_checks.ymlimprovements from the CI orchestrator branch (mrpollo/ci_orchestration, #26257) without doing the full T1/T2 split. Every change here matches a decision that was already made and validated on that branch.On
checks.ymlthe matrix loses five entries the orchestrator dropped:tests_coverage,px4_fmu-v2_default stack_check,NO_NINJA_BUILD=1 px4_fmu-v5_default,NO_NINJA_BUILD=1 px4_sitl_default, andpx4_sitl_allyes. Thecodecov/codecov-action@v1step goes with them (deprecated action, and it only ever ran for the droppedtests_coverageentry). What's left is the linter/lint-adjacent set plusmake testsandmodule_documentation. Of those,make testsis the only compile-heavy entry, so it gets thesetup-ccache/save-ccachecomposite actions wired around it (cache-key-prefix: ccache-sitl,max-size: 300M) — same config the orchestrator'sbasic-testsjob uses.On
python_checks.ymlthe oldapt-get install python3+pip install --break-system-packages+ hardcoded$HOME/.local/bin/mypy/$HOME/.local/bin/flake8pattern is replaced withactions/setup-python@v5pinned to 3.10. The linters run from PATH, no more break-system-packages workaround.Marking as a stacked PR so it picks up
fail-fast: true,fetch-depth: 1, and theConfigure Git Safe Directorystep extraction from #27032.