feat:[CORE-2016]Filter Additional columns for Policy API#2221
Open
AnandPaladin wants to merge 2 commits into
Open
feat:[CORE-2016]Filter Additional columns for Policy API#2221AnandPaladin wants to merge 2 commits into
AnandPaladin wants to merge 2 commits into
Conversation
AnandPaladin
requested review from
akashpaladin,
ershad-paladin,
plyubich and
santhosh-challa
akashpaladin
previously approved these changes
May 22, 2024
|
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (19,'Number of assets','assetCount','/admin/asset-group/filter'); | ||
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (19,'Created By','createdBy','/admin/asset-group/filter'); | ||
|
|
||
| INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (17,'DisabledReason','DisabledReason','/compliance/v1/filters/policy'); |
Contributor
There was a problem hiding this comment.
I believe display name for DisabledReason, DisabledOn and DisableExpiredOn should not be in camel case
Contributor
Author
There was a problem hiding this comment.
@ershad-paladin as of now this requirement is PUT ON HOLD. So holding this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is related to https://paladincloud.atlassian.net/browse/CORE-2016 where as part of this PR , we need to add additional attributes (disabledReaason/disabledOn,DisabledExpiryDate) as Filter for Policy List.
Problem
Solution
DB Changes
Fixes # (issue if any)
Type of change
Please delete options that are not relevant.
Checked the filter columns after making the DB changes.
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki