Skip to content

feat:[CORE-2016]Filter Additional columns for Policy API #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnandPaladin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat:[CORE-2016]Filter Additional columns for Policy API #2221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81bb354
fix:[CORE-2016]Filter DB Changes
AnandZemosa May 22, 2024
558105f
Adding serviceId for Admin Polciy
AnandZemosa May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions installer/resources/pacbot_app/files/DB.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,7 +1541,7 @@ INSERT IGNORE INTO pac_v2_ui_download_filters (serviceId,serviceName,serviceEndp
(16,'Recommendation','/api/asset/v1/recommendations'),
(17,'CloudNotificationsWithOutGlobal','/api/asset/v1/cloud/notifications?global=false'),
(18,'CloudNotificationsWithGlobal','/api/asset/v1/cloud/notifications?global=true');

INSERT IGNORE INTO pac_v2_ui_download_filters(serviceId,serviceName,serviceEndpoint) value(19,'AdminPolicies','/api/admin/policy/list');

INSERT IGNORE INTO pac_config_relation (`application`,`parent`) VALUES ('application','root');
INSERT IGNORE INTO pac_config_relation (`application`,`parent`) VALUES ('batch','application');
Expand Down Expand Up @@ -3119,7 +3119,9 @@ INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL)
INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (19,'Type','groupType','/admin/asset-group/filter');
INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (19,'Number of assets','assetCount','/admin/asset-group/filter');
INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (19,'Created By','createdBy','/admin/asset-group/filter');

INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (17,'DisabledReason','DisabledReason','/compliance/v1/filters/policy');
Copy link
Copy Markdown
Contributor

@ershad-paladin ershad-paladin May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe display name for DisabledReason, DisabledOn and DisableExpiredOn should not be in camel case

Copy link
Copy Markdown
Contributor Author

@AnandPaladin AnandPaladin May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ershad-paladin as of now this requirement is PUT ON HOLD. So holding this PR

INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (17,'DisabledOn','DisabledOn','/compliance/v1/filters/policy');
INSERT IGNORE INTO pac_v2_ui_options (filterId,optionName,optionValue,optionURL) VALUES (17,'DisableExpiredOn','DisableExpiredOn','/compliance/v1/filters/policy');
/* Plugin developed using PluginEngine V1 */
INSERT INTO pac_config_properties (`cfkey`,`value`,`application`,`profile`,`label`,`createdBy`,`createdDate`,`modifiedBy`,`modifiedDate`)
VALUES ('plugins.in.v1','gcp,redhat,contrast,checkmarx,crowdstrike,rapid7,wiz','job-scheduler','prd','latest','System',now(),NULL,NULL) ON DUPLICATE KEY UPDATE value = 'gcp,redhat,contrast,checkmarx,crowdstrike,rapid7', modifiedBy='System', modifiedDate=now();
Expand Down