Skip to content

feat:[NEXT-1926] Added Optional tags #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arunpaladin merged 1 commit into from
Jan 27, 2026
Merged

feat:[NEXT-1926] Added Optional tags #2388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions installer/resources/pacbot_app/files/DB.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3001,6 +3001,7 @@ END $$
DELIMITER ;

CALL update_filter_for_tag(@MANDATORY_TAGS);
CALL update_filter_for_tag(@OPTIONAL_TAGS);
Comment on lines 3003 to +3004

@coderabbitai coderabbitai Bot Jan 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Second call wipes mandatory-tag filters.

update_filter_for_tag deletes existing tag options before checking for empty input, so the optional-tag call removes previously inserted mandatory-tag filters (and if optional tags are empty, it clears everything). Consider merging both tag lists and calling the procedure once.

✅ Safer single-call approach 
-CALL update_filter_for_tag(`@MANDATORY_TAGS`);
-CALL update_filter_for_tag(`@OPTIONAL_TAGS`);
+CALL update_filter_for_tag(CONCAT_WS(',', `@MANDATORY_TAGS`, `@OPTIONAL_TAGS`));
🤖 Prompt for AI Agents 
In `@installer/resources/pacbot_app/files/DB.sql` around lines 3003 - 3004, The
second CALL to update_filter_for_tag(`@OPTIONAL_TAGS`) deletes filters inserted by
the first call because update_filter_for_tag removes existing tag options before
validating input; merge `@MANDATORY_TAGS` and `@OPTIONAL_TAGS` into a single tag
list (or build a combined variable) and call update_filter_for_tag once with
that merged list, or modify update_filter_for_tag to validate emptiness before
deleting; reference update_filter_for_tag and the variables
`@MANDATORY_TAGS/`@OPTIONAL_TAGS when making the change.



/* Updating resourceName for Azure target Type */
Expand Down
Loading