feat:[NEXT-1926] Added Optional tags

[arunpaladin]

feat:NEXT-1926 Added Optional tags

Summary by CodeRabbit

• New Features
  • Extended tag filtering capabilities to support optional tags in addition to existing mandatory tags. This enhancement enables users to configure more nuanced tag-based filters, providing greater flexibility and control over tag selection in filter operations and improving overall filtering configuration options.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The change adds invocations to update_filter_for_tag(@OPTIONAL_TAGS) in the database initialization script to extend the tagging UI configuration to include optional tags alongside mandatory tags.

Changes

Cohort / File(s)	Change Summary
Database Configuration installer/resources/pacbot_app/files/DB.sql	Adds call to update_filter_for_tag(@OPTIONAL_TAGS) in two locations to configure optional tags in the tagging UI filter setup

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat:[NEXT-1926] Added Optional tags to PolicyEngine #2387 — Directly related: both PRs modify DB.sql to support and configure OPTIONAL_TAGS functionality in the database initialization flow

Suggested reviewers

• kevin-paladin

Poem

🐰 Whiskers twitching with delight
Two calls added, tags take flight,
Optional filters configured just right,
Database blooms in moonlit light! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is largely incomplete, missing critical sections including Problem, Solution, Type of change, testing information, and checklist items required by the template.	Complete the description by adding Problem and Solution sections, selecting the change type, describing how the changes were tested, and completing the required checklist items.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly references the main change (adding optional tags) with issue tracking, though the prefix format is unconventional for this repository.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@installer/resources/pacbot_app/files/DB.sql`:
- Around line 3003-3004: The second CALL to
update_filter_for_tag(`@OPTIONAL_TAGS`) deletes filters inserted by the first call
because update_filter_for_tag removes existing tag options before validating
input; merge `@MANDATORY_TAGS` and `@OPTIONAL_TAGS` into a single tag list (or build
a combined variable) and call update_filter_for_tag once with that merged list,
or modify update_filter_for_tag to validate emptiness before deleting; reference
update_filter_for_tag and the variables `@MANDATORY_TAGS/`@OPTIONAL_TAGS when
making the change.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Second call wipes mandatory-tag filters.

update_filter_for_tag deletes existing tag options before checking for empty input, so the optional-tag call removes previously inserted mandatory-tag filters (and if optional tags are empty, it clears everything). Consider merging both tag lists and calling the procedure once.

✅ Safer single-call approach

-CALL update_filter_for_tag(`@MANDATORY_TAGS`);
-CALL update_filter_for_tag(`@OPTIONAL_TAGS`);
+CALL update_filter_for_tag(CONCAT_WS(',', `@MANDATORY_TAGS`, `@OPTIONAL_TAGS`));

🤖 Prompt for AI Agents

In `@installer/resources/pacbot_app/files/DB.sql` around lines 3003 - 3004, The
second CALL to update_filter_for_tag(`@OPTIONAL_TAGS`) deletes filters inserted by
the first call because update_filter_for_tag removes existing tag options before
validating input; merge `@MANDATORY_TAGS` and `@OPTIONAL_TAGS` into a single tag
list (or build a combined variable) and call update_filter_for_tag once with
that merged list, or modify update_filter_for_tag to validate emptiness before
deleting; reference update_filter_for_tag and the variables
`@MANDATORY_TAGS/`@OPTIONAL_TAGS when making the change.