Skip to content

Ice tile and rock#65

Merged
DevMichaelV merged 3 commits into
mainfrom
57-icesnow-tile
Apr 8, 2025
Merged

Ice tile and rock#65
DevMichaelV merged 3 commits into
mainfrom
57-icesnow-tile

Conversation

@zapturk

@zapturk zapturk commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator
  • added a rock
  • Added Ice tile that will slide the player
  • you can test in debug room

@zapturk zapturk linked an issue Apr 8, 2025 that may be closed by this pull request
- area was/is unused in ZEPlayer.gd
- changed inherit typing from enum to explicit typing as int in ZEGate.gd
@DevMichaelV DevMichaelV self-requested a review April 8, 2025 15:57

@DevMichaelV DevMichaelV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Just got a chance to look at this. Everything works well!

Feedback:

  • Would it be a dev-friendly move to make a pathway to get to the debug levels without changing the code in ZETitle.gd?
  • Would it be better if sliding on the ice was smooth and constant until hitting a barrier (e.g., a rock) or solid land?

Non-critical bugs I found
I found and fixed a slight typing issue with line 8 in ZEGate.gd; it was throwing a warning

# Old line - inherit typing from enum
@onready var currentState := state.closed

# New line - explicit typing as int
@onready var currentState: int = state.closed

I added an underscore in front of area on line 115 in ZEPlayer.gd as it was throwing a warning
func _on_ground_check_area_exited(_area: Area2D) -> void:

@DevMichaelV DevMichaelV merged commit e0c9885 into main Apr 8, 2025
@DevMichaelV DevMichaelV deleted the 57-icesnow-tile branch April 8, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ice/Snow tile

2 participants