Ice tile and rock#65
Merged
Merged
Conversation
zapturk
commented
Apr 8, 2025
Collaborator
- added a rock
- Added Ice tile that will slide the player
- you can test in debug room
Closed
- area was/is unused in ZEPlayer.gd - changed inherit typing from enum to explicit typing as int in ZEGate.gd
DevMichaelV
approved these changes
Apr 8, 2025
DevMichaelV
left a comment
Contributor
There was a problem hiding this comment.
Very cool. Just got a chance to look at this. Everything works well!
Feedback:
- Would it be a dev-friendly move to make a pathway to get to the debug levels without changing the code in
ZETitle.gd? - Would it be better if sliding on the ice was smooth and constant until hitting a barrier (e.g., a rock) or solid land?
Non-critical bugs I found
I found and fixed a slight typing issue with line 8 in ZEGate.gd; it was throwing a warning
# Old line - inherit typing from enum
@onready var currentState := state.closed
# New line - explicit typing as int
@onready var currentState: int = state.closedI added an underscore in front of area on line 115 in ZEPlayer.gd as it was throwing a warning
func _on_ground_check_area_exited(_area: Area2D) -> void:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.