-
Notifications
You must be signed in to change notification settings - Fork 727
[Python Compiler] Integration of Python Compiler #7367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7367 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 529 537 +8
Lines 50738 50873 +135
========================================
+ Hits 50583 50718 +135
Misses 155 155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
af6e9cd to
25014a4
Compare
8338660 to
0cc27bc
Compare
isaacdevlugt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the changelog! 😈
pennylane/compiler/python_compiler/transforms/apply_transform_sequence.py
Show resolved
Hide resolved
pennylane/compiler/python_compiler/transforms/transform_interpreter/__init__.py
Show resolved
Hide resolved
pennylane/compiler/python_compiler/transforms/transform_interpreter/interpreter/__init__.py
Show resolved
Hide resolved
pennylane/compiler/python_compiler/transforms/transform_interpreter/interpreter/impl.py
Show resolved
Hide resolved
.../compiler/python_compiler/transforms/transform_interpreter/transform_interpreter_catalyst.py
Outdated
Show resolved
Hide resolved
mudit2812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Erick, this is pretty impressive, but I'd be lying if I said I understood all of it. Can we chat about the implementation on Monday? I'd like to wrap my head around it a bit before approving.
PietropaoloFrisoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a # pragma no cover if testing is not an option right now : )
Co-authored-by: Mudit Pandey <[email protected]>
Definitely, I also need your help with the linter. I am not sure how to apply it 😅 In Catalyst we use a make format command. :) |
|
@mudit2812 or @PietropaoloFrisoni how can I run the linter from PennyLane, in Catalyst I use |
|
@erick-xanadu In PennyLane there's no Makefile, so I usually just format with |
|
Hey @erick-xanadu , if you use After this, the pre-commit hook (which includes black, pylint, and isort), should get run automatically every time you commit. |
|
@PietropaoloFrisoni and/or @mudit2812 is there a way to disable codecov? I already tried no cover. 🤔 |
|
@erick-xanadu this is a good reference. Apparently using |
|
@mudit2812 , I think your link says I should modify the pyproject.toml file: |
This reverts commit 3b275f5.
PietropaoloFrisoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @erick-xanadu !
Context: Initial integration with xDSL.
Description of the Change: Adds the initial integration for the python compiler. The
runfunction is intended to be called from Catalyst.[sc-89797]