-
Notifications
You must be signed in to change notification settings - Fork 234
Vue 3 Upgrade #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vue 3 Upgrade #1900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these are fixed except for the stream being too small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these should be actual buttons, not just text.
Targets shouldn't be a tab, it should always be visible on the side.
This is a little hard to read.
The font is also still different, but idk how important that is.
Enabling driver mode with any tab other than input selected means the input tab is not shown for driver mode. (Reloading does resolve this)
Grayed out buttons are really light, should be darker
more like this
…on/SimCameraProperties.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidebar font is a little small, let's increase that for readability
I'm not sure how I feel about the text color for selected options being blue on blue. That seems to be bad for readability/accessibility.
Log toggles are unaligned:
The log text is also really contrasting. I like the readability, but it might be hard on the eyes?
Also, all modals make the background lighter instead of darker. It's a change, but I'm not necessarily against it. I do think it's messing with my perception though, because I keep thinking that the modal color is darker than the normal UI (likely because the modal background is lighter, so of course I perceive it as darker.) It's kinda jarring.
Save and Close buttons need more contrast:
None of sliders seem to work for me? Sliding doesn't work, and inputting the numbers don't cause updates either.
I don't like how buttons that can't be clicked like the 3d toggle or cancel calibration button are lighter. "Grayed out" is a term that people use to describe these buttons.
Buttons here need some contrast to show you can interact with them:
Disabled save button color is bad, the old one was nicer (kinda contradicts what I said before, but I think it is just better):
Inconsistent size here isn't great:
A bit too much padding here:
The older, more compact style was good.
Sliders worked fine for me, but I tested prior to the updates to the sliders. Edit: further testing indicates sliders are indeed borked, likely caused by this commit |
Description
Upgrades to Vue 3 and necessary associated dependencies. This makes as few changes as required in order to lower review overhead and potential for breakage.
Closes #885
Meta
Merge checklist: