-
Notifications
You must be signed in to change notification settings - Fork 1
Outlier filter #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outlier filter #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I could run the tutorial without issue, just one question:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the change to this file intended to be in this PR? I don't see it mentioned in the docs change, but I do remember it getting in our way when we were working on the hardware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes it was, I didn't mention it because it only allows for additional functionality, shouldn't require any usage change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but I did have a question on expected behavior, see comment.
Changes from usage on hardware. To review, review code changes and run the fuse apriltag tutorial.