Outlier filter #28
Merged
Outlier filter #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyackzan
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Was the change to this file intended to be in this PR? I don't see it mentioned in the docs change, but I do remember it getting in our way when we were working on the hardware
Collaborator
Author
There was a problem hiding this comment.
Ah yes it was, I didn't mention it because it only allows for additional functionality, shouldn't require any usage change.
dyackzan
approved these changes
Apr 15, 2025
rlpratt12
reviewed
Apr 15, 2025
Collaborator
rlpratt12
left a comment
rlpratt12
left a comment
There was a problem hiding this comment.
Code looks good, but I did have a question on expected behavior, see comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from usage on hardware. To review, review code changes and run the fuse apriltag tutorial.