Skip to content

Outlier filter #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025
Merged

Outlier filter #28

merged 9 commits into from
Apr 15, 2025

Conversation

henrygerardmoore
Copy link
Collaborator

Changes from usage on hardware. To review, review code changes and run the fuse apriltag tutorial.

Copy link
Collaborator

@dyackzan dyackzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I could run the tutorial without issue, just one question:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change to this file intended to be in this PR? I don't see it mentioned in the docs change, but I do remember it getting in our way when we were working on the hardware

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes it was, I didn't mention it because it only allows for additional functionality, shouldn't require any usage change.

Copy link
Collaborator

@rlpratt12 rlpratt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I did have a question on expected behavior, see comment.

@henrygerardmoore henrygerardmoore enabled auto-merge (squash) April 15, 2025 22:33
@henrygerardmoore henrygerardmoore merged commit be740b5 into humble Apr 15, 2025
4 checks passed
@henrygerardmoore henrygerardmoore deleted the alternate_outlier_filter branch April 15, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants