Skip to content

Commit 69e0b55

Browse files
Remove disabled warnings in numericCast.h
1 parent be75edf commit 69e0b55

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

pxr/base/gf/numericCast.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@ template <class T, class U>
3030
constexpr bool
3131
GfIntegerCompareLess(T t, U u) noexcept
3232
{
33-
// XXX:
34-
// On Visual Studio warning C4018 (signed/unsigned mismatch) is emitted
35-
// when this function is used with boolean values. Just disable this
36-
// for now.
37-
#if defined(ARCH_COMPILER_MSVC)
38-
ARCH_PRAGMA_PUSH
39-
ARCH_PRAGMA(warning(disable:4018))
40-
#endif
41-
4233
static_assert(std::is_integral_v<T> && std::is_integral_v<U>);
4334

4435
if constexpr (std::is_signed_v<T> == std::is_signed_v<U>) {
@@ -50,10 +41,6 @@ GfIntegerCompareLess(T t, U u) noexcept
5041
else {
5142
return u >= 0 && t < std::make_unsigned_t<U>(u);
5243
}
53-
54-
#if defined(ARCH_COMPILER_MSVC)
55-
ARCH_PRAGMA_POP
56-
#endif
5744
}
5845

5946
enum GfNumericCastFailureType {

0 commit comments

Comments
 (0)