-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Apple: Usdrecord C++ port #3146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Filed as internal issue #USD-9815 ❗ Please make sure that a signed CLA has been submitted! |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jesschimein sorry, had a snafu and I'll get Lee added to our CLA asap. Might be a hot minute just because the necessary folks are on vacation. |
nvmkuruc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to have a version of usdrecord available with less dependencies.
I was wondering if it's possible to provide a deprecation warning for users using the -cam argument if it's no longer going to be supported.
|
I think any CLI11 doesn't not parse "short" options with more than one character, so we can't have |
|
I wonder if we should include a and yeah, like Lee suggests, it would have to be deprecated on the Python side. @meshula or @tcauchois do you have any thoughts? |
|
/AzurePipelines run |
|
@dgovil @ld-kerley Could you check for |
|
/AzurePipelines run |
4fe6129 to
06b3104
Compare
|
/AzurePipelines run |
add non-apple support for creating GL context using GLFW update build_usd.py to build GLFW when required
…r around GLFW resources
2173081 to
2caa880
Compare
Description of Change(s)
C++ port of usdrecord.
There are a few minor changes in the command line arguments due to CLI11 not supporting arguments of the form
-cam, instead we provide--cam.GLFW is used to provide an OpenGL context on non macOS platforms, macOS doesn't require an OpenGL context to render with usdrecord.
build_usd.pyhas been updated to build GLFW when required.Tests run and pass on both macOS and linux.
Fixes Issue(s)