Skip to content

Conversation

@ld-kerley
Copy link
Contributor

Description of Change(s)

C++ port of usdrecord.

There are a few minor changes in the command line arguments due to CLI11 not supporting arguments of the form -cam, instead we provide --cam.

GLFW is used to provide an OpenGL context on non macOS platforms, macOS doesn't require an OpenGL context to render with usdrecord.

build_usd.py has been updated to build GLFW when required.

Tests run and pass on both macOS and linux.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-9815

❗ Please make sure that a signed CLA has been submitted!

@jesschimein
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgovil
Copy link
Collaborator

dgovil commented Jul 2, 2024

@jesschimein sorry, had a snafu and I'll get Lee added to our CLA asap. Might be a hot minute just because the necessary folks are on vacation.

Copy link
Collaborator

@nvmkuruc nvmkuruc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to have a version of usdrecord available with less dependencies.

I was wondering if it's possible to provide a deprecation warning for users using the -cam argument if it's no longer going to be supported.

@ld-kerley
Copy link
Contributor Author

I think any -cam deprecation warning would need to be in a separate PR applied to usdrecord.py, and would only be useful if released before this C++ port.

CLI11 doesn't not parse "short" options with more than one character, so we can't have -cam, but I have added --cam as the closest fallback.

@dgovil
Copy link
Collaborator

dgovil commented Jul 3, 2024

I wonder if we should include a -cam deprecation warning in the changelog for 24.8?
Technically, even in argparse, multi character short-commands are bug prone (-cam is ambiguously -c -a -m or -cam)

and yeah, like Lee suggests, it would have to be deprecated on the Python side. @meshula or @tcauchois do you have any thoughts?

@jesschimein
Copy link
Collaborator

/AzurePipelines run

@nvmkuruc
Copy link
Collaborator

@dgovil @ld-kerley Could you check for -cam in argv and output a warning before passing it to cli11?

@jesschimein
Copy link
Collaborator

/AzurePipelines run

@ld-kerley ld-kerley force-pushed the usdrecord_cpp_port branch from 4fe6129 to 06b3104 Compare March 31, 2025 15:42
@jesschimein
Copy link
Collaborator

/AzurePipelines run

@ld-kerley ld-kerley force-pushed the usdrecord_cpp_port branch from 2173081 to 2caa880 Compare July 2, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants