[hdEmbree] Add a PxrIESFile class which mimics iesFile, with additional functionality (hdEmbree-UsdLux-PR16) #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmolodo
changed the title
This was referenced Jul 31, 2024
pmolodo
changed the title
2 tasks
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
5f3af3a to
3b9c6a2
Compare
Collaborator
|
Filed as internal issue #USD-9911 |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmolodo
changed the title
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
3b9c6a2 to
3042700
Compare
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
3042700 to
7eb43eb
Compare
pmolodo
changed the title
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
3 times, most recently
from
be38903 to
fd70f4c
Compare
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
fd70f4c to
4d353fa
Compare
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
2 times, most recently
from
36ca884 to
6839dfe
Compare
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
I've modified the behavior of inputs:ies:angleScale to match the "bimodal" formula I proposed here: |
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
3 times, most recently
from
e92c79b to
086ac24
Compare
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
1d0e8dc to
e138008
Compare
This modifies the hdEmbree example plugin to do direct lighting so as to provide a reference implementation of the expected behaviour for UsdLux. If no lights are present in the stage, the old ambient occlusion path will be used.
A few small utility functions from pbrt-v4
These are taken unaltered from cycles, v4.1.1 - https://projects.blender.org/blender/cycles/src/tag/v4.1.1/src/util/ies.h - https://projects.blender.org/blender/cycles/src/tag/v4.1.1/src/util/ies.cpp These are not yet built / used, but merely introduce the files for use in the codebase later.
default ...since, unlike Cycles, we intend to work in candela
pmolodo
force-pushed
the
pr/hdEmbree-pxrIES
branch
from
e138008 to
fdf0da0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Related PRs:
This PR is part of a chain of PRs that provide a reference implementation of UsdLux as part of hdEmbree.
Due to a github limitation, this PR must include all previous PRs in the chain. To see JUST the changes in this PR vs the previous in the chain, click this link
⛓️ All PRs in this chain:
📃 Documentation PR:
This chain of PRs (implementing UsdLux support in hdEmbree), was made separate from the PR documenting expected UsdLux behavior:
✳️ All UsdLux update related PRs:
To see ALL UsdLux update related PRs (documentation AND reference implementation) in one place, see:
⌛ Original PR:
These PRs are an update of this original PR:
But... why??
Why make these PRs in the first place?
The current specifications of the various UsdLux prims + attributes are imprecise or vague in many places, and as a result, actual implementations of them by various renderers have diverged, sometimes quite significantly. For instance, here is Intel's 4004 Moore Lane scene, with the same UsdLux lights defined, in 3 different renderers:
Karma:
Arnold:
Omniverse RTX:
For a full descpription of the problem, see here:
Why so many PRs?
This was my attempt to break up a rather large change into smaller, more easily reviewable changes, that can be merged in incrementally, to help ease the burden for code reviewers.
If you find this confusing, and would rather just one big PR (ie, just this one), or have them organized in some other way, please let me know!
Why are the documentation changes in their own PR?
In some ways, the documentation changes are the heart of this effort - we wish to specify more exactly what the various UsdLux prims and attributes represent. However, building consensus on this may take time - so we expect some dialogue on the exact language or formulas.
Because that may take time, the hdEmbree reference implementation changes are separate, and broken up, so we can hopefully start integrating portions of them even before final consensus has been reached on the final form of the specification.
Why are the documentation changes not broken up into smaller pieces, like the hdEmbree reference implementation changes?
Because I wasn't sure if that would be desirable or not! If people think that would be helpful, I can do so - perhaps breaking out by schema or individual attribute?