Skip to content

Conversation

@gvanush
Copy link

@gvanush gvanush commented Aug 22, 2024

Description of Change(s)

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@dgovil
Copy link
Collaborator

dgovil commented Aug 22, 2024

Hi, @gvanush ,
Thanks for putting up this PR.
We have another PR that adds imaging support here: #3215 and covers a little different ground.

It would be useful if you could provide feedback on that PR so we can track the support in one place. I think it captures most of your changes here with the exception of support for building in simulators.

I've stubbed in simulator build support here in the frameworks PR though that is based on top of my Imaging PR above #2969 in case that helps. However I'm currently refactoring this PR a bit to meet some feedback.

I'd appreciate any feedback of yours however on either PR.

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10011

❗ Please make sure that a signed CLA has been submitted!

@jesschimein
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gvanush
Copy link
Author

gvanush commented Aug 22, 2024

Hi, @gvanush , Thanks for putting up this PR. We have another PR that adds imaging support here: #3215 and covers a little different ground.

It would be useful if you could provide feedback on that PR so we can track the support in one place. I think it captures most of your changes here with the exception of support for building in simulators.

I've stubbed in simulator build support here in the frameworks PR though that is based on top of my Imaging PR above #2969 in case that helps. However I'm currently refactoring this PR a bit to meet some feedback.

I'd appreciate any feedback of yours however on either PR.

Great to hear @dgovil ! I just started with the iOS port but can use yours as it seems to work already.
One thing I needed and it works already is building for iOS simulator Arm 64. Also have a script (that maybe worth incorporating to the build usd script) to build xcframework from all Apple platform variations.

Is there an ongoing work for simulator support?

@gvanush gvanush closed this Aug 22, 2024
@dgovil
Copy link
Collaborator

dgovil commented Aug 22, 2024

I'm adding simulator support in the frameworks PR so it discovers the right sdk for both.

For xcframeworks, I haven't tried setting that up within OpenUSD directly yet because it would require doing multiple builds before the combining, but I do think it would make sense to have a script that does the multi build + combining

@dgovil
Copy link
Collaborator

dgovil commented Oct 7, 2024

I just wanted to reply here with an update:
Imaging support has been merged in and will be in USD 24.11 unless something goes wrong.
The Framework PR has updated support for Simulators and building as an XCFramework. It's now rebased on top of latest dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants