NVIDIA: Defensive check for UsdSkel_SkelAnimationQueryImp to avoid crash #3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggiezhang-nv
changed the title
Contributor
Author
|
@nvmkuruc for vis |
nvmkuruc
reviewed
Feb 25, 2025
pxr/usdImaging/usdSkelImaging/testEnv/testUsdSkelImagingSkeletonAdapter.cpp
Outdated
Show resolved
Hide resolved
roggiezhang-nv
force-pushed
the
anim_update_crash
branch
from
2cdbbee to
f367121
Compare
Collaborator
|
Filed as internal issue #USD-10701 (This is an automated message. See here for more information.) |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nvmkuruc
reviewed
Feb 28, 2025
|
|
||
| // Remove animation and update skelroot's visibility | ||
| { | ||
| SdfChangeBlock changeBlock; |
Collaborator
There was a problem hiding this comment.
It's not generally safe to call USD APIs in a SdfChangeBlock context. Is the SdfChangeBlock necessary?
Contributor
Author
There was a problem hiding this comment.
No, it isn't. I removed it.
roggiezhang-nv
force-pushed
the
anim_update_crash
branch
from
f367121 to
11ff1b9
Compare
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/AzurePipelines run |
roggiezhang-nv
force-pushed
the
anim_update_crash
branch
from
aee8f1f to
1c5893d
Compare
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
Removing animation prim with visiblity update to UsdSkelRoot may cause a crash. Closes PixarAnimationStudios#3544 (Internal change: 2369232)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Removing animation prim with visiblity update to UsdSkelRoot may cause crash to hydra code.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)