Fix build of usd executables when PXR_PY_UNDEFINED_DYNAMIC_LOOKUP is enabled #3577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
Sorry, I need to look into that, I plan to do this in the following days. |
|
Filed as internal issue #USD-10819 ❗ Please make sure that a signed CLA has been submitted! (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
3 tasks
|
/AzurePipelines run |
1 similar comment
|
/AzurePipelines run |
I submitted the signed CLA by email today. |
|
/AzurePipelines run |
The CLA was approved. |
10 tasks
|
/AzurePipelines run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Even if PXR_PY_UNDEFINED_DYNAMIC_LOOKUP is defined (to avoid that the usd python extensions links to the python library, to avoid problems with statically linked python interpreters) we want that executables that link usd_python to link with the Python library, as otherwise they would fail due to missing symbols, see #2371 and #2568.
This can be done by adding to INTERFACE_LINK_LIBRARIES the appropriate generator expression, that will evalute to empty when usd_python is linked to a library, but it will evaluate to Python3::Python when linked to an executable.
Link to proposal (if applicable)
Fixes Issue(s)
This needs to be verified by the specific persons that open the issues, but probably this will fix the following issues:
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)