Autodesk: Vulkan validation errors #3589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This binding seems unused, but Vulkan will complain about it anyway, since not binding it violates the pipeline layout.
|
Filed as internal issue #USD-10870 (This is an automated message. See here for more information.) |
|
/AzurePipelines run |
3 similar comments
|
/AzurePipelines run |
|
/AzurePipelines run |
|
/AzurePipelines run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
topologyVisibilitybinding. ThepipelineDrawBatchdoesn't bind this buffer for culling. It's not actually used, so not binding the buffer doesn't break anything, but Vulkan mandates that any buffer in a descriptor set layout (created by reflection) must be bound, regardless of its use. This caused a validation error. I moved the binding call so it now executes for both cull and draw.SubmitLayoutChangeshould return the old layout so restoring it isn't as error proneLink to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)