Provide quiet status specialization for python #3609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Tf_PythonCallContext
assumes that a validmoduleName
andfunctionName
are available and joins them with.
. However, whenTf.Status
is called withverbose=False
,moduleName
andfunctionName
are both empty.This yields a non-empty
fullName
of.
when consumed by downstream diagnostic delegates that could be confusing.This PR introduces a "quiet" version of
_Status
which bypassesTf_PyCallContext
and provides an explicitly emptyTfCallContext
.Link to proposal (if applicable)
Fixes Issue(s)
#3311
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)