[usdUtils] Prevent ComputeAllDependenciesClient from adding invalid layers #3647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Filed as internal issue #USD-11035 (This is an automated message. See here for more information.) |
nvidia-jomiller
force-pushed
the
dev_fix_usdutils_compute_deps
branch
4 times, most recently
from
64880bc to
7ee5a8f
Compare
nvidia-jomiller
force-pushed
the
dev_fix_usdutils_compute_deps
branch
from
7ee5a8f to
1ad2055
Compare
…ayers UsdUtils_ComputeAllDependenciesClient would output invalid layers if a layer fails to open. If the layer does not open correctly, a warning will be posted
nvidia-jomiller
force-pushed
the
dev_fix_usdutils_compute_deps
branch
from
1ad2055 to
dfb3bf9
Compare
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
…ayers `UsdUtils_ComputeAllDependenciesClient` would output invalid layers if a layer fails to open. A check is added to make sure the layer opens correctly. If the layer does not open correctly, a warning will be issued Closes PixarAnimationStudios#3647 (Internal change: 2370359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
UsdUtils_ComputeAllDependenciesClientwould output invalid layers if a layer fails to open. A check is added to make sure the layer opens correctly. If the layer does not open correctly, it will be added to unresolvedPathsLink to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)