Skip to content

Conversation

@dgovil
Copy link
Collaborator

@dgovil dgovil commented Jul 7, 2025

Description of Change(s)

This PR overhauls the current code signing setup with the following changes:

  1. Developers can now pass in code signing identifiers directly to the build_usd.py script.
  2. Codesigning identifiers are now passed to CMake for Xcode targets if they want to sign anything.
  3. The code signing identifier is calculated less often
  4. Codesigning now supports signing frameworks
  5. Codesigning supports checking previous signing status and only re-signing as needed. Note: Since USD's cmake always installs all targets again, they're always re-signed. Future work might help optimize this, but at the least we're not re-signing every dependency.
  6. Codesigning is validated earlier to prevent running through a whole build just to find code signing fails

This makes code signing much more reliable and faster overall.

This work is needed to enable properly building OpenUSD as a framework

Checklist

@dgovil dgovil requested a review from davidgyu July 7, 2025 18:47
@dgovil dgovil added needs review Issue needing input/review by the repo maintainer (Pixar) build Build-related issue/PR labels Jul 7, 2025
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-11198

(This is an automated message. See here for more information.)

Copy link
Contributor

@sunyab sunyab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgovil , left some notes from a first pass review. Thanks!

@dgovil
Copy link
Collaborator Author

dgovil commented Nov 14, 2025

Thanks, @sunyab !
I'll take a pass next week at resolving these

@dgovil dgovil force-pushed the codesigning-improvements branch from d1be066 to 0983b32 Compare November 26, 2025 20:05
@dgovil
Copy link
Collaborator Author

dgovil commented Nov 26, 2025

Thanks, @sunyab
I pushed an update that also rebases on top of dev.

Appreciate the notes. Hope you have a good thanksgiving break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build-related issue/PR needs review Issue needing input/review by the repo maintainer (Pixar)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants