[usdlux] fix formula for inputs:ies:angleScale (missing +pi term) #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Ali Fatoorechi for catching this!
pmolodo
added a commit
to pmolodo/OpenUSD
that referenced
this pull request
Jul 24, 2025
pmolodo
added a commit
to pmolodo/OpenUSD-proposals
that referenced
this pull request
Jul 24, 2025
pmolodo
added a commit
to pmolodo/OpenUSD-proposals
that referenced
this pull request
Jul 24, 2025
1 task
Collaborator
|
Filed as internal issue #USD-11271 (This is an automated message. See here for more information.) |
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
My [original proposal of a bimodal formula for ies:angleScale](https://github.com/pmolodo/OpenUSD/blob/ies-angleScale-findings-questions/pxr/usd/usdLux/iesAngleScale/UsdLux-IESAngleScale-FindingsAndQuestions.md) included a `+ ` term when `angleScale < 0`: $$ \frac{\theta_{light} - \pi}{-angleScale} + \pi, \newline \quad\text{if } {angleScale < 0} \\ $$ ...and my [actual implementation of the formula for an HdEmbree reference UsdLux renderer](PixarAnimationStudios@fdf0da0#diff-77b2c6df291efe4099038fa3e6d029fac5e1dd4eb2638675f2de3af4e7ea892fR140) includes the `+ ` term: ```cpp theta = (_pi<float> - theta) / angleScale + _pi<float>; ``` ...but somehow I left it out of [the schema docs](https://github.com/PixarAnimationStudios/OpenUSD/blob/d0d5c33d5655f206a02b58311efa841890fb3894/pxr/usd/usdLux/schema.usda#L853): ``` <sub>ies</sub> = (<sub>light</sub> - ) / -angleScale ``` This fixes that mistake. Thanks Ali Fatoorechi for catching this! (Updates from original PR: Also updated same incorrect formula in usdLux user docs (schemaUserDoc.usda) and re-generated appropriate markdown.) Closes PixarAnimationStudios#3753 (Internal change: 2374194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
My original proposal of a bimodal formula for ies:angleScale included a
+ πterm whenangleScale < 0:...and my actual implementation of the formula for an HdEmbree reference UsdLux renderer includes the
+ πterm:...but somehow I left it out of the schema docs:
This fixes that mistake.
Thanks Ali Fatoorechi for catching this!
Link to proposal (if applicable)
PixarAnimationStudios/OpenUSD-proposals#77
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)