Allow point-instanced prototypes to inherit their instancer's visibility #3769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instancer prototypes. This prevents users from (even temporarily) making their prototypes invisible to remove them from the generated image. Instead, this change moves the data to an *underlay* where explicit visibility authoring will effectively be respected. This is linked to issue PixarAnimationStudios#3748 and also lays a bit more groundwork to address issue PixarAnimationStudios#3693
…lity, including a dependency to track updates (i.e., if the instancer's visibility is dirtied, the prototype's visibility will be dirtied)
Collaborator
|
Filed as internal issue #USD-11326 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Allow point-instanced prototypes to inherit their instancer's visibility through a custom data source.
Link to proposal (if applicable)
Fixes Issue(s)
#3693
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)