Skip to content

UsdSkelImaging Hydra 2.0: Use rest transforms if the animation is empty. #3874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+10 −0
Open

UsdSkelImaging Hydra 2.0: Use rest transforms if the animation is empty. #3874

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pxr/usdImaging/usdSkelImaging/skelData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,16 @@ _ComputeJointLocalTransforms(
return UsdSkelImagingGetTypedValue(restTransforms);
}

// If all transform components were empty, that could mean:
// - the attributes were never authored
// - the attributes were blocked
// - the attributes were authored with empty arrays (possibly intentionally)
// In many of these cases, we should expect the animation to be silently
// ignored, so throw no warning.
if (animTransforms.empty()) {
return UsdSkelImagingGetTypedValue(restTransforms);
}

if (data.animMapper.IsIdentity()) {
return animTransforms;
}
Expand Down
Loading