Remove _CRT_SECURE_NO_WARNINGS from testArchUtil
#3885
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
_CRT_SECURE_NO_WARNINGSis defined in two places on Windows.OpenUSD/pxr/base/arch/testenv/testArchUtil.cpp
Line 7 in a32790e
OpenUSD/cmake/defaults/msvcdefaults.cmake
Line 88 in a32790e
This yields the following warning when building
testArchUtil.This PR removes the unneeded
_CRT_SECURE_NO_WARNINGS. It's not clear what warning_CRT_SECURE_NO_WARNINGSwas being introduced to suppress intestArchUtilas disabling both the#defineandmsvcdefaults.cmakedoesn't yield any additional warnings intestArchUtil.Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)