Skip to content

Conversation

@nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Nov 3, 2025

Description of Change(s)

_CRT_SECURE_NO_WARNINGS is defined in two places on Windows.

#define _CRT_SECURE_NO_WARNINGS

_add_define("_CRT_SECURE_NO_WARNINGS")

This yields the following warning when building testArchUtil.

testArchUtil.cpp(7): warning C4005: '_CRT_SECURE_NO_WARNINGS': macro redefinition
testArchUtil.cpp: note: see previous definition of '_CRT_SECURE_NO_WARNINGS'

This PR removes the unneeded _CRT_SECURE_NO_WARNINGS. It's not clear what warning _CRT_SECURE_NO_WARNINGS was being introduced to suppress in testArchUtil as disabling both the #define and msvcdefaults.cmake doesn't yield any additional warnings in testArchUtil.

Link to proposal (if applicable)

Fixes Issue(s)

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-11620

(This is an automated message. See here for more information.)

@pixar-oss pixar-oss closed this in ae10bff Nov 26, 2025
@nvmkuruc nvmkuruc deleted the remove-unneeded-define branch November 26, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants