APPLE: Make Accessibility Priority variable #3886
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been showing the USD Accessibility API to more members of the accessibility community and a request was made to make priority not be time varying. Originally, we made this uniform because we were thinking of it as a way to help prioritize accessibility purposes globally, but have realized that this would also benefit from being varying. For example, if there was an accessibility purpose that was only high priority for a given part of an animation, like flashing red lights, that would be useful for a system to know when it changes. Looking at the USD code and spec, this should be a change that doesn't necessitate versioning the schema. Coupled with the low likelihood of anything having adopted the schema yet, and the even lower likelihood of people using the priority attribute yet, I think this is a safe assumption. I've done a few tests to make sure that nothing in USD seems to get mad when the uniform token is taken away or added as well, and all seems fine.
Collaborator
|
Filed as internal issue #USD-11621 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
We have been showing the USD Accessibility API to more members of the accessibility community and a request was made to make priority not be time varying. Originally, we made this uniform because we were thinking of it as a way to help prioritize accessibility purposes globally, but have realized that this would also benefit from being varying.
For example, if there was an accessibility purpose that was only high priority for a given part of an animation, like flashing red lights, that would be useful for a system to know when it changes. These would be temporary priority increases as a result.
Looking at the USD code and spec, this should be a change that doesn't necessitate versioning the schema. Coupled with the low likelihood of anything having adopted the schema yet, and the even lower likelihood of people using the priority attribute yet, I think this is a safe assumption. I've done a few tests to make sure that nothing in USD seems to get mad when the uniform token is taken away or added as well, and all seems fine.
This should only be an issue if someone authored a file after this PR was merged with time sampled information and tried to read it into an older version of USD where the attribute was uniform. But in that case it appears USD will default to reading just the static default value, which we always recommend be authored.
Therefore I'd posit that this does not require versioning since its loosening things up, and the impact is very low.
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)