Better tracking of instancer prims that get retyped via PrimsAdded#4042
Open
robp-sidefx wants to merge 1 commit intoPixarAnimationStudios:devfrom
Open
Better tracking of instancer prims that get retyped via PrimsAdded#4042robp-sidefx wants to merge 1 commit intoPixarAnimationStudios:devfrom
robp-sidefx wants to merge 1 commit intoPixarAnimationStudios:devfrom
Conversation
…r prims, retyped via PrimsAdded, are removed from _instancersAndOvers
Collaborator
|
Filed as internal issue #USD-12098 (This is an automated message. See here for more information.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Previously, new entries (in PrimsAdded) were filtered to identify instancers, and those paths were added to a local cache. But this didn't capture the event where an existing instancer was retyped. This change also captures the non-instancers from the new entries, and uses that list to remove entries that might be in the cache from an earlier representation of the scene.
I expect this new code path will get hit a lot (i.e., the vast majority of PrimsAdded prims will not be instancers), so I am mildly nervous about potential performance implications, but I can't immediately come up with a lighter-weight alternative. I can verify that the change resolves the reported issue, but you may have a more elegant solution instead.
Link to proposal (if applicable)
Fixes Issue(s)
#4040
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)