Skip to content

Bark block #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Bark block #1215

wants to merge 5 commits into from

Conversation

Argmaster
Copy link
Collaborator

@Argmaster Argmaster commented Mar 19, 2025

This pull request adds bark block for existing wood types. Basically a wood block but covered with bark on all sides. Additionally it used stair rotation mode to allow creation of greater detail on trees.

Bark blocks drop normal logs when broken.
There is a crafting recipe for converting logs into corresponding bark blocks and converting bark block into planks.

Screenshot 2025-03-19 231356

@Argmaster
Copy link
Collaborator Author

Argmaster commented Mar 19, 2025

Although they probably should not be used extensively in world generation due to possible performance penalties, but players really can make wonders with block like this.

@OneAvargeCoder193
Copy link
Contributor

aren't log tops used in the simple tree as branches? should those be replaced with log branches instead?

@Argmaster
Copy link
Collaborator Author

@OneAvargeCoder193 current tree models are not here to stay, there is #1207 to replace current generation. Although I suppose I should check if the data values used for tops as branches should be updated in SimpleTreeModel.

@careeoki
Copy link
Contributor

I think we should wait for #357 before doing this. With log rotation, tops can be used to hide the log_top texture when making curvy trees or large branches.
Also, "oak top" wouldn't make sense anymore. They should be called "oak bark"

@Argmaster
Copy link
Collaborator Author

Ok, maybe it should just be a separate thing, cubyz:oak_bark at all and we could allow tops to rest in peace.

@Argmaster Argmaster marked this pull request as draft March 29, 2025 14:57
@Argmaster Argmaster changed the title Make log tops use stair rotation Bark block Apr 4, 2025
@Argmaster Argmaster marked this pull request as ready for review April 11, 2025 14:53
@Argmaster Argmaster marked this pull request as draft April 11, 2025 17:11
@Argmaster Argmaster marked this pull request as ready for review May 9, 2025 20:22
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a third block type for each tree, I would prefer having a rotation mode that combines them all into one block.
We could easily support 3 bits for log rotation, 2 bits for whether it has a bark top or bottom and 8 bits for all stair states.

@Argmaster
Copy link
Collaborator Author

Ehh it's one of those.
I guess I will work on it.

@Argmaster Argmaster marked this pull request as draft May 21, 2025 19:21
@Argmaster
Copy link
Collaborator Author

Taken by OneAvargeCoder193 in #1496

@Argmaster Argmaster closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants