-
Notifications
You must be signed in to change notification settings - Fork 69
Bark block #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bark block #1215
Conversation
Although they probably should not be used extensively in world generation due to possible performance penalties, but players really can make wonders with block like this. |
aren't log tops used in the simple tree as branches? should those be replaced with log branches instead? |
@OneAvargeCoder193 current tree models are not here to stay, there is #1207 to replace current generation. Although I suppose I should check if the data values used for tops as branches should be updated in |
I think we should wait for #357 before doing this. With log rotation, tops can be used to hide the log_top texture when making curvy trees or large branches. |
Ok, maybe it should just be a separate thing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding a third block type for each tree, I would prefer having a rotation mode that combines them all into one block.
We could easily support 3 bits for log rotation, 2 bits for whether it has a bark top or bottom and 8 bits for all stair states.
Ehh it's one of those. |
Taken by OneAvargeCoder193 in #1496 |
This pull request adds bark block for existing wood types. Basically a wood block but covered with bark on all sides. Additionally it used stair rotation mode to allow creation of greater detail on trees.
Bark blocks drop normal logs when broken.
There is a crafting recipe for converting logs into corresponding bark blocks and converting bark block into planks.