Skip to content

Signs #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Signs #1446

wants to merge 13 commits into from

Conversation

IntegratedQuantum
Copy link
Member

@IntegratedQuantum IntegratedQuantum commented May 14, 2025 •
edited
Loading

  • Rotation (already merged)
  • basic GUI
  • sign models and textures
  • sign blocks
  • update the text on the client
  • Figure out block entity rendering
  • Render the text to a texture on update
  • Render the texture in the world in the location of the sign
  • Use varint instead of u32 for storing the block data lengths, (now, while we can still change it)
  • Sync the text with the server and all clients
  • Figure out block entity storage on the server
  • Send the entity data of the initial chunk
  • Store the text on the server
  • Rethink some of the API (do we need onPlace/onBreak, when there is unload and updateData?)

fixes #367

IntegratedQuantum added a commit that referenced this pull request May 20, 2025
@IntegratedQuantum
Refactor how block entity unloading works and unloading things on the…
f82ab0c 
… client side

extracted from #1446
@IntegratedQuantum IntegratedQuantum mentioned this pull request May 20, 2025
Merged
IntegratedQuantum added a commit that referenced this pull request May 21, 2025
@IntegratedQuantum
Refactor how block entity unloading works and unloading things on the…
c852393 
… client side (#1475)

extracted from #1446
Argmaster
Argmaster reviewed May 21, 2025
View reviewed changes
@IntegratedQuantum
Add helper variable for visible character count
23f91b7
@IntegratedQuantum
Return an optional from remove for block entities to allow clearing t…
0419018 
…heir data.

Also returning null is no longer considered a failure state, since it makes sense for blocks with empty state (e.g. an empty chest) to have no entry at all in the block entity data
@IntegratedQuantum IntegratedQuantum mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Argmaster Argmaster Argmaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signs
3 participants
@IntegratedQuantum @Argmaster @careeoki