1 line readability fix in renderer #2316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntegratedQuantum
requested changes
Nov 19, 2025
| const neighborBlock = block; | ||
| oldBlock = mesh_storage.getBlockFromRenderThread(neighborPos[0], neighborPos[1], neighborPos[2]) orelse return; | ||
| block = oldBlock; | ||
| // Check if the neighbor block has a block and that it is the same type as the placed item |
Member
There was a problem hiding this comment.
The first part "Check if the neighbor block has a block" makes no sense, what does it mean for a block to have a block???
And the second part "that it is the same type as the placed item" is just describing the code, and in my opinion is not more or less readable than block.typ == itemBlock. If you think this part is unclear then a better choice would be to use a more descriptive variable name instead of a comment.
So overall in my opinion this comment, in its current state, makes the code more confusing than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a comment here as it took me a few hours to figure out what it was checking for.
will help readability