Allow allocators in testing #2320
Conversation
|
I discourage this change. Sharing allocators, or in more general terms, resources across tests may result in absurd interactions which are very hard to track down. |
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Please also reroute the stack allocator to the testing_allocator, the testing code should run without any additional setup, and most importantly it should do leak tests without you having to remember to call deinitThreadLocals.
| globalArenaAllocator = undefined; | ||
| if(globalGpa.deinit() == .leak) { | ||
| std.log.err("Memory leak", .{}); | ||
| if(!builtin.is_test) { |
There was a problem hiding this comment.
This function shouldn't be called during testing.
| pub var globalGpa = std.heap.GeneralPurposeAllocator(.{.thread_safe = true}){}; | ||
| pub var handledGpa = ErrorHandlingAllocator.init(globalGpa.allocator()); | ||
| pub var globalGpa: std.heap.GeneralPurposeAllocator(.{.thread_safe = true}) = if(builtin.is_test) undefined else .init; | ||
| pub var handledGpa = ErrorHandlingAllocator.init(if(builtin.is_test) std.testing.allocator else globalGpa.allocator()); |
There was a problem hiding this comment.
In my opinion this should be done at the declaration of the interface. Instead I'd propose to have a globally accessible testing allocator that is std.testing.allocator wrapped in the error handling allocator.
3 participants
Fixes #1286