Experimental mesh light sampling improvements by caching the samples#2542
Draft
IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
Draft
Experimental mesh light sampling improvements by caching the samples#2542IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
IntegratedQuantum wants to merge 1 commit intoPixelGuys:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it does reduce block placement lag significantly (9 ms → 7.5 ms) to the point where it only takes 20% of the remaining latency on the render thread (most of the work is distributed). The main bottleneck (when placing white glowcrystals) is now light propagation with around ²⁄₃ of the latency.
However this comes at a cost of increased complexity and decreased generation throughput.