Conversation
|
could you please upload a video of how that looks? |
|
yes. |
|
I'm going to try this out! |
ikabod-kee
left a comment
ikabod-kee
left a comment
There was a problem hiding this comment.
I don't know how you did it, but you managed to get it feeling right on the very first try. No complaints from me. Well done!!
(Now we just have to make our up & down bobbing meet the same quality as this!)
|
Can we add an option for enabling/disabling bobbing? |
Should that disable the vertical movement (i.e. when jumping/falling) as well (which is what Minecraft does, for example), or should it just disable the bobbing that is being added by this PR? |
2026-02-13.14-28-29.mp4It seems the animation doesn't reset when stopping and starting. Also a slow fade-in like you suggested in the Discord would make sense! |
2026-02-13.14-28-29.mp4Also when jumping around, the item always seems to go to the right position, even when jumping when it's positioned to the left. |
|
Wait I just posted the same video twice 😭 my bad. 2026-02-13.14-31-39.mp4 |
|
One thing that is weird is how fast the bobbing frequency slows down when you move slower. It feels like one of these toys that have wave their arm as you move them over the ground. In real life if you walk slower, then your step length also reduces, ranging from maybe 1/4 of a meter to several meters when sprinting. Here your step length seems to be constant. |
* Add bob intensity with fade in and fade out * Set a minimum for movementScale for calculating bobPhase * Don't revert bobbing while jumping * Reset bobPhase and bobIntensity when flying
This is intentional. I think it would look weirder if the item being held just kept going in the same direction every time you pressed W. That said, I don't think it matters all that much, since this isn't something that you would be doing during actual gameplay. |
|
@ikabod-kee Feel free to test it again, I've made some changes that should make it look better. |
|
Alright! I'll get to it soon |
ikabod-kee
left a comment
ikabod-kee
left a comment
There was a problem hiding this comment.
Okay, this is definitely a lot better now! I will make one suggestion right quick though:
Could you make it so the hand slows down its animation when jumping instead of immediately stopping?
|
Also, when they are airborne, could you make it so the hand (very) slowly goes back to the original position? (with some easing, of course) 
|
|
Another complaint: The fade-in for going from stopped to running is too long. |
Can you tell me the value that you'd prefer? You can test a few values by adjusting the
No worries, all good. |
Sure, I can tell you! Where can I find this setting? |
|
It's a constant defined in the code. I don't think it makes sense to introduce a GUI setting for this, instead, I just added one to turn bobbing on or off entirely, because I think that's what most players would be looking for. |
|
Where is it in the code? I'm not a programmer XD |
|
Line 580 in src/itemdrop.zig. |
|
I decided on 5.0 as the "fadeInSpeed" value, because I like how snappy it feels. You immediately know when you are walking! |
|
I actually think having it be an immediate start/stop when pressing the walk keys would make it feel extremely responsive! The only issue I really have with the bobbing otherwise would how it acts when airborne. |
ikabod-kee
left a comment
ikabod-kee
left a comment
There was a problem hiding this comment.
You managed to fix most of my complaints with this recent commit! It's pretty much ready to merge, but I ask that you try to make the animation reset when stopped so that the bobbing goes right every time you begin walking. I believe this will help a bit in its "feel."
Basically "trust me bro."
|
Oh, and if you can, could you make it so going into fly mode doesn't immediately jerk it like this? 2026-02-13.22-12-43.mp4 |
|
It'd also be nice to have the player only bob when a movement key is held, so it doesn't look like they're walking on ice when they're sliding (because you know, they're sliding.) You don't have to do this one as I feel tying it to movement keys may leave a slight period in between switching directions that can stop the animation. Unless you want to. It's just a "would be nice to have" thing. 2026-02-13.22-27-30.mp4 |
|
Going into fly mode is smoother now, and sliding on ice should look better as well. |
|
I love the little detail you added where the item gets lowered when crouch-walking. |
|
I've noticed that running down feels kind of weird with the way the animation resets in the air: video-2026-02-15_10.30.38.mp4 |
|
I've made some adjustments to the animation reset speed (e.g., when running down hillsides). It's fairly subjective, but I'm pretty happy with how it looks now. |
5 participants
This PR adds bobbing so that walking doesn't feel "on-rails".